Support fmt::runtime with wchar_t in fmt::format_to_n#4715
Support fmt::runtime with wchar_t in fmt::format_to_n#4715vitaut merged 9 commits intofmtlib:masterfrom
Conversation
vitaut
left a comment
There was a problem hiding this comment.
Thanks for the PR. We shouldn't modify base.h for this.
How about reimplementing similar functions in |
|
I think what we need here as an overload of |
|
what about char16_t? |
|
Let's focus on |
I use wformat_string in the new implementation. This may remove previous support of char type not in |
|
I modified the original overload. I also added new tests for Please give me feedback about the new test cases. This is new for this repository. |
vitaut
left a comment
There was a problem hiding this comment.
Let's avoid the macros in tests and just focus on wchar_t case.
|
Ok, I will revert it to 1dcff42. |
|
Merged, thanks! |
resolves #4714